Auto create tile for multiple atlases

[thiagola92]

Based on issues: #69273 #79473
And PRs: #70790 #79558

• Support for auto create tiles when adding multiple atlases
• Button to add Atlas can be used for multiple files
• Unify functions TileSetEditor::_texture_file_selected() and TileSetEditor::_drop_data_fw() into TileSetEditor::_load_texture_files()

Bugsquad edit:

• Fixes Can't batch create atlas tiles when dragging multiple images into TileSet editor #69273
• Fixes Atlas Merging Tool not working #79473

[groud]

Thanks for the contribution!

Why do you create 3 functions to do handle that, and store atlases as a property of the editor ? I would suggest to instead use a single function that takes an array instead, it would be simpler.

[Chaosus]

And commits needs to be squashed in order for PR to be accepted (see https://docs.godotengine.org/en/latest/contributing/workflow/pr_workflow.html).

[thiagola92]

@groud I really didn't want to store atlases as a property but I don't know how to get the array after the user accept/decline a popup.

void TileSetAtlasSourceEditor::init_source(Vector<Ref<TileSetAtlasSource>> atlases) {
	tool_setup_atlas_source_button->set_pressed(true);
	atlases_to_auto_create_tiles = atlases;
	confirm_auto_create_tiles->popup_centered();
}

_clear_auto_create_tiles() created for when the user cancel the popup.
_auto_create_tiles_in_atlas() i think that i'm going to move the logic back to _auto_create_tiles()
Can you tell me the third function? init_source() existed before to deal with the popup.

@Chaosus Thank you, I will read and do right after any adjustment from feedbacks

[groud]

@groud I really didn't want to store atlases as a property but I don't know how to get the array after the user accept/decline a popup.

Ah I see what you mean. I think it's fine to do it that way then, using a property. However I would probably move the definition closer to the popup's one in the .h file, so that's it's a bit more obvious this variable is only needed for the popup.

[thiagola92]

@groud Like this?

void _auto_create_tiles();
void _auto_remove_tiles();
void _cancel_auto_create_tiles();
AcceptDialog *confirm_auto_create_tiles = nullptr;

Also I renamed _clear_auto_create_tiles() to _cancel_auto_create_tiles().

[groud]

I meant something like this:

void _auto_create_tiles();
void _auto_remove_tiles();
void _cancel_auto_create_tiles();
AcceptDialog *confirm_auto_create_tiles = nullptr;
Vector<Ref<TileSetAtlasSource>> atlases_to_auto_create_tiles;

Related variables and methods close together.

[thiagola92]

@groud Sorry, fixed.
@Chaosus Squashed.

[groud]

Needs a rebase, but I believe looks mostly good.

[thiagola92]

Moved the comment // Handle dropping a texture in the list of atlas resources. back to _drop_data_fw()

[thiagola92]

@groud Can you confirm if i did rebase correctly?

[thiagola92]

@AThousandShips thank you for reviewing.
Changed as requested.

[akien-mga]

Thanks! And congrats for your first merged Godot contribution 🎉