Support metadata in MultiNodeEdit #71345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Small hack for metadata to work there (similar to existing script hack). Does not appear within its own category, not sure if its worth hacking it (would need to be hacked in inspector). Fixes godotengine#59604.
Calinou
reviewed
Jan 13, 2023
| if (F.name == "script") { | ||
| continue; // Added later manually, since this is intercepted before being set (check Variant Object::get()). | ||
| } else if (F.name.begins_with("metadata/")) { | ||
| F.name = F.name.replace_first("metadata/", "Metadata/"); // Trick to not get actual metadata edited from MultiNodeEdit. |
There was a problem hiding this comment.
If this hack is to prevent actual MultiNodeEdit metadata from being edited, can we use something more obvious such as "_metadata"? Uppercase vs lowercase may be difficult to distinguish.
There was a problem hiding this comment.
MultiNodeEdit actual metadata is not editable, so this is not a problem
akien-mga
approved these changes
Jan 21, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small hack for metadata to work there (similar to existing script hack). Does not appear within its own category, not sure if its worth hacking it (would need to be hacked in inspector).
Fixes #59604.