Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GDScript] Perform update-and-assign operations in place when possible (reverted) #72056

Merged
merged 1 commit into from
Mar 20, 2023
Merged

[GDScript] Perform update-and-assign operations in place when possible (reverted) #72056

merged 1 commit into from
Mar 20, 2023

Conversation

resistor
Copy link
Contributor

This turns two bytecode operations into one by using the assignment destination directly as the output of the binary operator. This manifests in operations like +=.

Benchmark: https://hastebin.com/mibabadisu
Old byte code: https://hastebin.com/iboqopicaw
New byte code: https://hastebin.com/awefuneyow

@resistor
[GDScript] Perform update-and-assign operations in place when possible.
22a0c20 
This turns two bytecode operations into one by using the assignment
destination directly as the output of the binary operator. This manifests
in operations like `+=`.
@resistor resistor requested a review from a team as a code owner January 25, 2023 16:23
@akien-mga akien-mga added this to the 4.x milestone Jan 25, 2023
@resistor
Copy link
Contributor Author

Ping

@YuriSizov YuriSizov modified the milestones: 4.x, 4.1 Mar 20, 2023
@YuriSizov YuriSizov merged commit a008a06 into godotengine:master Mar 20, 2023
@YuriSizov
Copy link
Contributor

Thanks!

In future commits I recommend not using your master branch as a base. Prefer creating feature branches, so you can work on multiple commits at once, have a clear and sync master, and avoid issues with rebasing.

@AThousandShips AThousandShips mentioned this pull request Apr 9, 2023
Closed
@AThousandShips AThousandShips mentioned this pull request Apr 10, 2023
Merged
@akien-mga akien-mga changed the title [GDScript] Perform update-and-assign operations in place when possible. [GDScript] Perform update-and-assign operations in place when possible (reverted) Apr 25, 2023
@akien-mga
Copy link
Member

Reverted by #75885 as it introduced regressions.

@resistor resistor mentioned this pull request Apr 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vnen vnen vnen approved these changes

Assignees
No one assigned
Labels
enhancement performance topic:gdscript
Projects
None yet
Milestone
4.1
Development

Successfully merging this pull request may close these issues.
4 participants
@resistor @YuriSizov @akien-mga @vnen