[GDScript] Fix incorrect compound assignment #75885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
force-pushed
the
compound_fix
branch
4 times, most recently
from
76b6827 to
7a15621
Compare
AThousandShips
force-pushed
the
compound_fix
branch
from
7a15621 to
c7a8b87
Compare
Reverts in-place compound assignments Added test to ensure correctness
AThousandShips
force-pushed
the
compound_fix
branch
from
c7a8b87 to
e5365da
Compare
|
As this is a relatively destructive bug with very confusing effects and unpredictable I feel reverting is best, as it was a performance change Considered commenting out the broken code and adding a fixme pointing to the issue, but think it's best to leave it a clean slate for future work on the feature |
|
i can confirm that this fixes #76041 |
vnen
approved these changes
Apr 25, 2023
|
Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts in-place compound assignments
Added test to ensure correctness
Added tests for array assignments as well, as per #76041
Found that this causes further bugs and decided to just revert the change and leave it up for future fixes as it seems very tricky and many pitfalls
This reverts #72056
Fixes #75832
Fixes #76041
Regression from #72056