Make restart in NodeStateMachine / NodeTransition optional #72450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Jan 31, 2023
TokageItLab
force-pushed
the
optional-restart
branch
2 times, most recently
from
5d2c239 to
86c1d96
Compare
TokageItLab
force-pushed
the
optional-restart
branch
from
86c1d96 to
8d96fd3
Compare
|
Renamed to |
lyuma
approved these changes
Jan 31, 2023
There was a problem hiding this comment.
I noticed that the code for AnimationNodeTransition::_process is effectively doing set_parameter("current_state", get_parameter("transition_request")) every frame.
However, Tokage explained that in this case, Current state is "A". Transition_request is also "A". so it is a no-op during a transition to self.
LGTM
TokageItLab
force-pushed
the
optional-restart
branch
from
8d96fd3 to
4525181
Compare
|
Just for the sake of performance, I changed it to skip the A=A process. |
|
Okay, it's a bit easier to read now. thanks |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up #71418.
Recognizing that many users are spamming
travel()requests, this feature will be made optional.