C#: Fix line position when opening file in VSCode #73584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Feb 19, 2023
neikeq
approved these changes
Feb 19, 2023
|
Thanks! |
raulsntos
added
the
cherrypick:3.x
This was referenced Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73576
Line and column use 1 based indices in VSCode.
This leaves MonoDevelop as the only external C# editor that doesn't have the +1 for the column (every editor now has it for the line). I am can't test to confirm if this is correct, but since column 0 is the only one ever used by godot and thus it doesn't actually matter, so I left that bit alone.