-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: Fix line in OpenInExternalEditor #79404
C#: Fix line in OpenInExternalEditor #79404
Conversation
849363e
to
fdea8c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also works in VS, but the built-in editor now points to the line above.
fdea8c8
to
132a1da
Compare
I looked into this and reached the conclusion that The The double subtract should also be happening with GDScript errors, but in there there is a call to As a consequence of these changes this is likely no longer cherry-pickable for 3.x and I have removed the label. If this change is desired for 3.x, a backport PR can be made. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't notice any more issues
Thanks! |
Cherry-picked for 4.1.3. |
Note for 3.x cherrypick: Requires also cherry-picking C#: Fix line position when opening file in VSCode #73584.