Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete properties in tween_property #76591

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Autocomplete properties in tween_property #76591

merged 1 commit into from
Dec 14, 2023

Conversation

HolonProduction
Copy link
Member

@HolonProduction HolonProduction requested a review from a team as a code owner April 29, 2023 21:13
@HolonProduction HolonProduction force-pushed the complete-tween branch 2 times, most recently from cd04505 to 7923268 Compare April 29, 2023 21:16
@Calinou Calinou added this to the 4.x milestone Apr 29, 2023
@KoBeWi
Copy link
Member

KoBeWi commented Oct 11, 2023

Autocompletion does not work well with custom classes:
image
There are no properties from base native class.

@HolonProduction HolonProduction force-pushed the complete-tween branch 2 times, most recently from 8a43c67 to 2dab77f Compare October 14, 2023 13:25
AThousandShips
AThousandShips reviewed Oct 14, 2023
View reviewed changes
modules/gdscript/gdscript_editor.cpp Outdated Show resolved Hide resolved
modules/gdscript/gdscript_editor.cpp Outdated Show resolved Hide resolved
modules/gdscript/gdscript_editor.cpp Outdated Show resolved Hide resolved
@HolonProduction
Copy link
Member Author

Autocompletion does not work well with custom classes: There are no properties from base native class.

Should handle inheritance correctly now.

KoBeWi
KoBeWi approved these changes Oct 14, 2023
View reviewed changes
Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works correctly on the editor side.

@akien-mga akien-mga changed the title Autocomplete properties in tween_property. Autocomplete properties in tween_property. Oct 16, 2023
@YuriSizov YuriSizov modified the milestones: 4.x, 4.3 Dec 13, 2023
adamscott
adamscott approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine!

@YuriSizov YuriSizov changed the title Autocomplete properties in tween_property. Autocomplete properties in tween_property Dec 14, 2023
@YuriSizov YuriSizov merged commit 5c99558 into godotengine:master Dec 14, 2023
15 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@Mickeon Mickeon mentioned this pull request Jan 3, 2024
Open
@HolonProduction HolonProduction deleted the complete-tween branch October 5, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@KoBeWi KoBeWi KoBeWi approved these changes

@adamscott adamscott adamscott approved these changes

Assignees
No one assigned
Labels
enhancement topic:animation topic:editor topic:gdscript
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.

Add property autocompletion for tween_property()
6 participants
@HolonProduction @KoBeWi @YuriSizov @adamscott @AThousandShips @Calinou