-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autocompletion for OS.has_feature()
#86747
base: master
Are you sure you want to change the base?
Conversation
I was answering back but the comment was deleted.
Maybe and ideally, the two need to be united somehow. |
Indeed, noticed that it was just as I had commented, my bad 🙂 I'd say to either unite it with the other one, or use the list directly to avoid the step |
d5bc8a5
to
92c0fee
Compare
I think I came with a nice compromise, but the OS needs to know about EditorExport which is still not nice, so perhaps as a last resort I would have to hardcode it like #76591 has done, into |
6a37e25
to
4bf1fc5
Compare
4bf1fc5
to
89b48b8
Compare
Thank you. It'll probably compile now, but we'll then see what are the thoughts on code quality |
89b48b8
to
65aea28
Compare
Closes godotengine/godot-proposals#4240.
The implementation borrows from ProjectSettingsEditor, putting into EditorExport for OS to access.
But this causes a dependency on the editor class...