Correctly reset particle size and rotation in ParticlesProcessMaterial #78021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: clayjhn <claynjohn@gmail.com>
akien-mga
approved these changes
Jun 8, 2023
|
Thanks! |
|
Thank you! |
|
Cherry-picked for 4.0.4. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #55396
Fixes: #68809
Supercedes: #55397 (rebased and addressed comments)
The original issue was caused by particle scale persisting after the particle is reset. Local testing showed that the same issue was occurring with particle rotation as well. So both scale and rotation need to be reset when flagged to do so.
Thanks to @RPicster for figuring out the correct fix in the first place!