Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix doc_status.py trying to get removed version tag from XML #79406

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Fix doc_status.py trying to get removed version tag from XML #79406

merged 1 commit into from
Jul 14, 2023

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented Jul 13, 2023 •
edited
Loading

This also runs doc_status.py on CI to catch potential future regressions.

@Calinou Calinou requested a review from a team as a code owner July 13, 2023 03:21
@Calinou Calinou added this to the 4.2 milestone Jul 13, 2023
@YuriSizov
Copy link
Contributor

PS: I suggest making doc_status.py run on CI, so we can catch this kind of regression earlier in the future 🙂 It's pretty fast to run.

Feel free to update this PR to include it.

@Calinou
Fix doc_status.py trying to get removed version tag from XML
c16db09 
This also runs `doc_status.py` on CI to catch potential future regressions.
@Calinou Calinou requested a review from a team as a code owner July 13, 2023 14:26
@Calinou
Copy link
Member Author

Calinou commented Jul 13, 2023

Feel free to update this PR to include it.

Done 🙂

@YuriSizov YuriSizov merged commit d087eb7 into godotengine:master Jul 14, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YuriSizov YuriSizov YuriSizov approved these changes

Assignees
No one assigned
Labels
bug documentation enhancement topic:buildsystem
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@Calinou @YuriSizov