Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add placeholder items to TileSet layer list #79676

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Add placeholder items to TileSet layer list #79676

merged 1 commit into from
Jul 24, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jul 19, 2023 •
edited
Loading

Adds a fake item + tooltip telling how to setup layers:
image

Before:
image

@KoBeWi KoBeWi added this to the 4.2 milestone Jul 19, 2023
@KoBeWi KoBeWi requested a review from groud July 19, 2023 22:39
@KoBeWi KoBeWi force-pushed the MissingNo.Layers branch from d8211b8 to 9e0e001 Compare July 19, 2023 22:39
@KoBeWi KoBeWi requested a review from a team as a code owner July 19, 2023 22:39
@groud
Copy link
Member

groud commented Jul 20, 2023

Thanks! I think the solution is ok-ish, but I feel those items are maybe grabbing attention too much. Would it be possible to tone them down a bit ? Like setting them as "disabled" or something like that ?

@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 20, 2023

image

@KoBeWi KoBeWi force-pushed the MissingNo.Layers branch from 9e0e001 to 76a1708 Compare July 20, 2023 11:57
@groud
Copy link
Member

groud commented Jul 20, 2023

image

Nice! Maybe we should do the same for the Icon too (I don't know if we have a modulation option for the icon ?) . That would be perfect IMO.

@KoBeWi @MewPurPur
Add placeholder items to TileSet layer list
bb64588 
Co-authored-by: MewPurPur <mew.pur.pur@abv.bg>
@KoBeWi KoBeWi force-pushed the MissingNo.Layers branch from 76a1708 to bb64588 Compare July 20, 2023 12:31
@KoBeWi
Copy link
Member Author

KoBeWi commented Jul 20, 2023

image

groud
groud approved these changes Jul 20, 2023
View reviewed changes
Copy link
Member

@groud groud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing! Looks perfect to me!

@YuriSizov YuriSizov merged commit dbff173 into godotengine:master Jul 24, 2023
@KoBeWi KoBeWi deleted the MissingNo.Layers branch July 24, 2023 17:42
@YuriSizov
Copy link
Contributor

Thanks!

@AThousandShips AThousandShips mentioned this pull request Oct 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MewPurPur MewPurPur MewPurPur left review comments

@YuriSizov YuriSizov YuriSizov approved these changes

@groud groud groud approved these changes

Assignees
No one assigned
Labels
enhancement topic:editor usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@KoBeWi @groud @YuriSizov @MewPurPur