Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make animation name list scroll to new animation in SpriteEditor #79743

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Make animation name list scroll to new animation in SpriteEditor #79743

merged 1 commit into from
Jul 24, 2023

Conversation

TokageItLab
Copy link
Member

(Salvage) Supersedes #75322. Closes #74185.

Must be scrolled at the correct selection timing.

@TokageItLab TokageItLab added this to the 4.2 milestone Jul 21, 2023
@TokageItLab TokageItLab requested review from dalexeev and a team July 21, 2023 10:36
@TokageItLab @DarellLdark
Make animation name list scroll to new animation in SpriteEditor
99451b5 
Co-authored-by: DarellLdark <darell.ldark@gmail.com>
@TokageItLab TokageItLab changed the title Make animation name list scroll to new animation in SpriteEdiotr Make animation name list scroll to new animation in SpriteEditor Jul 21, 2023
dalexeev
dalexeev approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I tested the changes, it works correctly. Side effect: when changing the animation in the Inspector, the animation list scrolls too, but I think it's right and convenient.

adamscott
adamscott approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@adamscott adamscott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved during the animation/asset-pipeline team meeting. Thanks!

@YuriSizov YuriSizov mentioned this pull request Jul 24, 2023
Closed
@YuriSizov YuriSizov merged commit 7dbbf2e into godotengine:master Jul 24, 2023
13 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@TokageItLab TokageItLab deleted the fix-name-list-asp branch February 14, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamscott adamscott adamscott approved these changes

@aaronfranke aaronfranke aaronfranke approved these changes

@dalexeev dalexeev dalexeev approved these changes

Assignees
No one assigned
Labels
enhancement topic:animation topic:editor usability
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

Animation window: creating new animation beyond bottom of scrollview doesn't auto-scroll to bottom
5 participants
@TokageItLab @YuriSizov @adamscott @aaronfranke @dalexeev