Fix Tree check propagation not unchecking parent items #79946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YuriSizov
changed the title
YuriSizov
changed the title
Ymanawat
force-pushed
the
propagate-check-79942
branch
from
3e2a607 to
214440d
Compare
|
@AThousandShips I've updated the PR, have a look. |
Ymanawat
force-pushed
the
propagate-check-79942
branch
from
214440d to
24dbd47
Compare
|
I tested the newest version of this PR and it doesn't fix the issue. |
Ymanawat
force-pushed
the
propagate-check-79942
branch
from
24dbd47 to
2673f70
Compare
Ymanawat
force-pushed
the
propagate-check-79942
branch
from
2673f70 to
cf91caf
Compare
|
@KoBeWi @AThousandShips Actually I've tested the issue then updated the PR, in my local build it was working. But I think I found that the issue now : Lines 186 to 188 in 031aa99 when the check is already false, set by the set_indeterminate function. I'm passing any_checked which is false in case of no child selected, it won't continue to set the indeterminate to false. Line 191 in 031aa99 I think the changes I made now should fix the issue. |
Ymanawat
force-pushed
the
propagate-check-79942
branch
from
cf91caf to
f0362cd
Compare
KoBeWi
approved these changes
Jul 28, 2023
|
Thanks! And congrats on your first merged Godot PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR focuses on
4.xbranches and resolves a tree selection bug that exists in various application sections, including theme editor, asset installation and import. The bug caused problems with deselecting parents when all children were deselected.Fixes : #79942
2023-07-27.13-12-03.1.mp4
Additionally, tested the bug in the
3.5.2stable version, where parents are automatically checked if any child is selected, and there is no indeterminate check in that version.