Fix storing invalid item height values in ItemList
#82660
Conversation
coumcashier
changed the title
coumcashier
changed the title
Calinou
added
the
cherrypick:4.1
coumcashier
changed the title
YuriSizov
changed the title
ItemList
YuriSizov
added
the
cherrypick:3.x
The height of the last N items is incorrectly overwritten with the max height of first row (N = number of columns). This happen in the first iteration of the while loop. Moving this code inside if (all_fit) makes sure the last rows height is only updated at the end when max height (max_h) is calculated for the last row.
YuriSizov
force-pushed
the
itemlist_height_fix
branch
from
4d9b01a to
1533292
Compare
There was a problem hiding this comment.
Seems to work correctly and the explanation makes sense.
The code hasn't changed since #4847, so I would assume this fix would be relevant to 3.x as well.
I rebased and reworded your commit on your behalf. Please be mindful of your commit messages in the future, we prefer them to follow a similar style.
|
Should someone open a PR with the |
I think it should be cherry-pickable, i.e. it will be done by maintainers. If not, they will remove the label and leave a comment about it. |
|
Thanks! |
YuriSizov
removed
the
cherrypick:4.1
|
Cherry-picked for 4.1.4. |
fixes #80793
Last n items' height is incorrectly overwritten with the max height of first row (n = number of columns). This happens in the first iteration of the while loop. Moving this code inside if (all_fit) makes sure the last rows height is only updated at the last iteration of the while loop when max height (max_h) is calculated for the last row.
after
before
The 3rd last item has incorrect height because it is using the first rows height. the last 3 items correct height was lost.