Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix comment typo in gdscript_parser.h #83792

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix comment typo in gdscript_parser.h #83792

merged 1 commit into from
Oct 24, 2023

Conversation

ryanabx
Copy link
Contributor

@ryanabx ryanabx commented Oct 22, 2023

Very simple PR. Found a typo while looking through gdscript_parser.h today.

@ryanabx ryanabx requested a review from a team as a code owner October 22, 2023 19:47
@ryanabx ryanabx changed the title Fix typo in gdscript_parser.h Fix typo in gdscript_parser.h Oct 22, 2023
@ryanabx ryanabx changed the title Fix typo in gdscript_parser.h Fix comment typo in gdscript_parser.h Oct 22, 2023
@dalexeev dalexeev added this to the 4.2 milestone Oct 22, 2023
dalexeev
dalexeev approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@dalexeev dalexeev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'm wondering if there are spell checkers (other than codespell) that will find more typos? By the way, I remembered another typo:

godot/modules/gdscript/editor/gdscript_translation_parser_plugin.cpp

Line 43 in 8c25a98

// Extract all translatable strings using the parsed tree from GDSriptParser.

@akien-mga
Copy link
Member

Might be worth fixing that "GDSript" typo in this same PR indeed.

@ryanabx ryanabx force-pushed the fixes/gdscript-parser-typo branch from 9035e63 to e945a8f Compare October 23, 2023 13:48
@ryanabx
Copy link
Contributor Author

ryanabx commented Oct 23, 2023

Might be worth fixing that "GDSript" typo in this same PR indeed.

Done

@akien-mga akien-mga merged commit 9d4fe33 into godotengine:master Oct 24, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@cmumme cmumme mentioned this pull request Dec 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dalexeev dalexeev dalexeev approved these changes

Assignees
No one assigned
Labels
bug topic:codestyle topic:gdscript
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
4 participants
@ryanabx @akien-mga @dalexeev @AThousandShips