Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in XRInterface comment #86652

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

cmumme
Copy link
Contributor

@cmumme cmumme commented Dec 30, 2023

Corrects a typo (the -> they) in xr_interface.h on the XRInterface class' comment.

@cmumme cmumme requested a review from a team as a code owner December 30, 2023 19:10
@AThousandShips
Copy link
Member

Thank you for your contribution

This is a very small change for a whole PR, I think this should instead be part of a larger style and spelling fix PR that are some times done, along with applying spell checking directly

@cmumme
Copy link
Contributor Author

cmumme commented Dec 30, 2023

Thank you for your contribution

This is a very small change for a whole PR, I think this should instead be part of a larger style and spelling fix PR that are some times done, along with applying spell checking directly

Hi, thank you for your quick response. Similar PRs about the same size have been merged in the past. (e.g. #83792) Despite this, merging this into a larger PR as has also been done in cases like #85141 would also make sense.

servers/xr/xr_interface.h Outdated Show resolved Hide resolved
Copy link
Contributor

@dsnopek dsnopek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@akien-mga akien-mga modified the milestones: 4.x, 4.4 Sep 11, 2024
@akien-mga akien-mga merged commit 2cfd8f7 into godotengine:master Sep 11, 2024
18 checks passed
@akien-mga
Copy link
Member

Thanks! And congrats for your first merged Godot contribution 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants