Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove margins from editor scrollbars #83868

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Oct 24, 2023

Fixes #79994

As identified in #80013, the problem was that the scrollbar background was using content margins. That's because make_stylebox() adds texture margin to content margin, which probably makes sense, but not in this case.

@KoBeWi KoBeWi added this to the 4.2 milestone Oct 24, 2023
@KoBeWi KoBeWi requested a review from YuriSizov October 24, 2023 00:09
@YuriSizov YuriSizov added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Oct 27, 2023
Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You know, I kind of thought this was done on purpose 🙃

@akien-mga akien-mga merged commit a725e84 into godotengine:master Oct 27, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@KoBeWi KoBeWi deleted the −5_just_because branch October 27, 2023 15:47
@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor scroll bar's gutter don't reach its ends
3 participants