Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid return from some _get/_set #84054

Merged
merged 1 commit into from
Oct 27, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Oct 27, 2023

Invalidly returned true on the non-matched path, these do not break anything by blocking inherited properties, at least not right now

There are some remaining cases for Skeleton and SkeletonModification*, but they are a bit more complicated so not touching them right now, these were the trivial cases

@AThousandShips AThousandShips added bug topic:rendering cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release labels Oct 27, 2023
@AThousandShips AThousandShips added this to the 4.2 milestone Oct 27, 2023
Invalidly returned `true` on the non-matched path
@AThousandShips AThousandShips changed the title Fix invalid return from ArrayMesh::_get Fix invalid return from some _get/_set Oct 27, 2023
@AThousandShips
Copy link
Member Author

Given the very varying style and format of the _get/_set methods across the codebase I might look at unifying them at some point, they follow a number of different styles of handling different paths and it's error prone to modify them

Copy link
Contributor

@YuriSizov YuriSizov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. Would appreciate the @godotengine/animation team to confirm that there is no required magic going on with those (if there is, we ought to add comments about that, not just leave it as is).

@AThousandShips
Copy link
Member Author

AThousandShips commented Oct 27, 2023

if there is, we ought to add comments about that, not just leave it as is

Indeed, will go over the animation cases later and open a PR for them but they require a bit more work, and will add comments there otherwise if there's some reason

Edit: Was checking if the 3.x version also needed fixing but it appears it has a very different code for these cases, and looks like the error snuck in with the refactoring of it

@akien-mga akien-mga merged commit e654592 into godotengine:master Oct 27, 2023
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the mesh_fix branch October 27, 2023 15:47
@AThousandShips
Copy link
Member Author

Thank you!

@donn-xx
Copy link

donn-xx commented Oct 27, 2023

Magic!

@YuriSizov YuriSizov removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Jan 23, 2024
@YuriSizov
Copy link
Contributor

Cherry-picked for 4.1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

if "string" in ArrayMesh—Always returns true
4 participants