Comment the shader template light function by default #84594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a minor usability tweak. The light functions replace the default ones, so even if empty they will avoid the current shader to have proper lighting and users will have no idea why. Code was changed to have the shader function commented by default, indicating that uncommenting replaces the default function.
clayjohn
approved these changes
Nov 7, 2023
akien-mga
added
the
cherrypick:4.2
|
Thanks! |
|
Cherry-picked for 4.2.1. |
YuriSizov
removed
the
cherrypick:4.2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor usability tweak.
The light functions replace the default ones, so even if empty they will avoid the current shader to have proper lighting and users will have no idea why.
Code was changed to have the shader function commented by default, indicating that uncommenting replaces the default function.
Bugsquad edit: fixes: #84639