Validate texture format selection when exporting to Windows or Linux #84913
Conversation
clayjohn
added
bug
topic:export
cherrypick:4.2
|
|
||
| if (uses_s3tc != uses_bptc) { | ||
| valid = false; | ||
| err += TTR("If using either s3tc or bptc texture format, you must use both s3tc and bptc."); |
There was a problem hiding this comment.
| err += TTR("If using either s3tc or bptc texture format, you must use both s3tc and bptc."); | |
| err += TTR("If using either S3TC or BPTC texture format, you must enable both."); |
|
Seems a bit pointless to me to have Maybe we should unify them as The compatibility with the old preset properties could likely be handled with |
That sounds fine to me. I didn't realize we had the ability to use |
I haven't checked if that would actually work, to be clear. But it's worth testing. |
Absolutely. I'll take a look and see what I can do |
| @@ -58,16 +58,16 @@ | |||
| - [code]{cmd_args}[/code] - Array of the command line argument for the application. | |||
| </member> | |||
| <member name="texture_format/bptc" type="bool" setter="" getter=""> | |||
| If [code]true[/code], project textures are exported in the BPTC format. | |||
| If [code]true[/code], project textures are exported in the BPTC format. If used, [member texture_format/s3tc] must be used as well. | |||
There was a problem hiding this comment.
| If [code]true[/code], project textures are exported in the BPTC format. If used, [member texture_format/s3tc] must be used as well. | |
| If [code]true[/code], project textures are exported in the BPTC format. If enabled, [member texture_format/s3tc] must be enabled as well. |
Same for all these
I've done that in #88325, please review :) |
|
Superseded by #88325 |
AThousandShips
removed
the
cherrypick:4.2
Fixes: #81234
Closes: godotengine/godot-proposals#7230
In #73829 we made s3tc + bptc the default export options. But we exposed users to the risk that, if they disable one or the other, their games would not load.
In Godot 4.x, it is not possible to use S3TC without BPTC (or vice versa). Nor is it possible to use ETC2 without ASTC (or vice versa).
This change validates that S3TC and BPTC have the same value (either both on or both off) and either S3TC/BPTC or ETC2/ASTC are used at export time.
Finally it updates the docs for the settings and removes "etc" from the feature list (as ETC textures are no longer used by the engine).