Make script/shader editor save shortcuts unique again #84931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This brings back the "detached Script Editor loses focus" bug. #83290 would need to be merged first. |
Actually we use it for "Save all scenes". I missed it because it uses a different syntax for defining a keystroke (we should unify it for the codestyle's sake!). So maybe I should just remove the default shortcut from script's/shader's "Save as". Let me know. |
Makes sense I suppose, let's go back to the 4.1 shortcuts and re-assess for 4.3. |
YuriSizov
force-pushed
the
editor-hot-topic-hot-keys
branch
from
b8a1455
to
0f5a14c
Compare
|
Done! |
akien-mga
approved these changes
Nov 15, 2023
|
Thanks! |
This was referenced Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #79337 because this change became a source of controversy and was vetoed. The old shortcut for saving scripts is back, it's
Alt + Ctrl + S, which means the problem with focus #79337 was trying to hide will become obvious again. That's the trade-off.I maintained the addition of a default shortcut for "Save as" but for consistency addedRemoved it as it conflicted with "Save all scenes".Altto it as well, so it'sAlt + Ctrl + Shift + S. This combination doesn't seem to be used anywhere at this time.For the shader editor I replicated these same shortcuts. I think it makes sense to have these specific shortcuts contextual, so you can decide to save a script or a shader without any interference, while
Ctrl + Ssaves the scene as before regardless of the editor and your context.This is an immediate alternative to #84623 to unblock the 4.2 release, because #84623 tries to address some of the problems with the old behavior in an unfavorable manner, IMO. It also makes the current behavior impossible to achieve even if you set shortcuts to be the same on your end. So it doesn't benefit the other half of our users who liked the change from the old to the current.