Handle global classes when resolving type from PropertyInfo
#85215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just noticed we have the same behavior in the Analyzer. Should probably be changed there as well. |
HolonProduction
force-pushed
the
type-from-property-class-name
branch
from
84114a7 to
c9dba82
Compare
vnen
approved these changes
Jan 17, 2024
HolonProduction
force-pushed
the
type-from-property-class-name
branch
from
c9dba82 to
4ab985d
Compare
|
Did the analyzer change as well |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes partially #74888
Fixes partially #71296
Fixes partially #78454
Fixes partially #77643
Fixes partially godotengine/godot-proposals#8545 (Should be closed if #85239 is merged)
In theory we could also resolve to
CLASStype if the file is GDScript but we would need to pass the completion context through the whole type resolve chain to add the depending parser. Not quite sure if this is worth the trouble.Edit:
Sorting doesn't work since
_get_property_locationdoesn't handle global classes. But I am a fan of smaller self contained PR's.