Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle global classes when resolving property location #85239

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Handle global classes when resolving property location #85239

merged 1 commit into from
Jan 25, 2024

Conversation

HolonProduction
Copy link
Member

@HolonProduction HolonProduction commented Nov 22, 2023 •
edited
Loading

Fixes partially #74888
Fixes partially #71296
Fixes partially #78454

Fixes partially #77643

Fixes partially godotengine/godot-proposals#8545 (Should be closed if #85215 is merged)

@HolonProduction HolonProduction requested a review from a team as a code owner November 22, 2023 19:55
@AThousandShips AThousandShips added this to the 4.3 milestone Nov 22, 2023
@HolonProduction HolonProduction mentioned this pull request Nov 25, 2023
Merged
@HolonProduction HolonProduction mentioned this pull request Dec 30, 2023
Closed
@YuriSizov
Copy link
Contributor

YuriSizov commented Jan 17, 2024 •
edited
Loading

(partially)

If all of these issues are not fully fixed, then please put this between Fixes and the issue number, so that we don't auto-close them. Same should be done to the other two PRs. If all of them together actually do close these issues, then the last one we merge must mark them as resolved.

@HolonProduction HolonProduction mentioned this pull request Jan 17, 2024
Merged
@HolonProduction HolonProduction force-pushed the global-class-property-location branch from 963ca06 to 05551f0 Compare January 17, 2024 20:57
@HolonProduction HolonProduction requested a review from vnen January 17, 2024 21:01
vnen
vnen approved these changes Jan 24, 2024
View reviewed changes
Copy link
Member

@vnen vnen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YuriSizov
Copy link
Contributor

Needs a rebase though!

AThousandShips
AThousandShips approved these changes Jan 24, 2024
View reviewed changes
modules/gdscript/gdscript_editor.cpp Outdated Show resolved Hide resolved
modules/gdscript/gdscript_editor.cpp Outdated Show resolved Hide resolved
modules/gdscript/gdscript_editor.cpp Outdated Show resolved Hide resolved
modules/gdscript/gdscript_editor.cpp Outdated Show resolved Hide resolved
@HolonProduction HolonProduction force-pushed the global-class-property-location branch from 05551f0 to c99e4f8 Compare January 24, 2024 17:06
@HolonProduction
Copy link
Member Author

Needs a rebase though!

Done

@YuriSizov
Copy link
Contributor

@HolonProduction Is this the last PR needed to fully address the linked issues?

@HolonProduction
Copy link
Member Author

@HolonProduction Is this the last PR needed to fully address the linked issues?

godotengine/godot-proposals#8545 can be closed (preferably as "not planed")

#74888, #71296 and #78454 are already closed because another fix made the code path from this PR irrelevant to them.

#77643 consists of multiple points, some of which still need to be addressed.

@YuriSizov YuriSizov merged commit 9579dc6 into godotengine:master Jan 25, 2024
16 checks passed
@YuriSizov
Copy link
Contributor

Thanks!

@paulloz paulloz mentioned this pull request Apr 23, 2024
Open
@akien-mga akien-mga added the cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release label Apr 23, 2024
@HolonProduction HolonProduction deleted the global-class-property-location branch October 5, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AThousandShips AThousandShips AThousandShips approved these changes

@vnen vnen vnen approved these changes

Assignees
No one assigned
Labels
bug cherrypick:4.2 Considered for cherry-picking into a future 4.2.x release topic:editor topic:gdscript usability
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
5 participants
@HolonProduction @YuriSizov @vnen @AThousandShips @akien-mga