Add gate sound effect #86104
Add gate sound effect #86104
Conversation
|
my test example if it saves anyone time |
|
@YuriSizov what are the review rules for the less active Godot Engine teams? |
| ClassDB::bind_method(D_METHOD("get_threshold_db"), &AudioEffectGate::get_threshold_db); | ||
|
|
||
| ADD_PROPERTY(PropertyInfo(Variant::FLOAT, "threshold_db", PROPERTY_HINT_RANGE, "-100,0,0.01,suffix:dB"), "set_threshold_db", "get_threshold_db"); | ||
| } |
|
|
|
The extra parameters seem to work completely fine now, freezing commits here unless there are any more review changes or system-specific issues that my computer isn't running into |
|
Please merge into one commit as we review. Note that it'll require manual approval of cicd for first time contributors. |
|
not sure how to rebase on the gate-sound-effect-rebase branch, i've just been making a new branch every time (using commandline git) |
|
See this documentation, if you need help with squashing. |
marc-weber1
force-pushed
the
gate-sound-effect-rebase
branch
from
75b657c to
40a61df
Compare
There was a problem hiding this comment.
Tested locally (rebased on top of master 811ce36), it works as expected. Code looks good to me.
My only concern is about the default values, where it feels the noise gate is barely doing anything by default due to its very low threshold. With my microphone (Blue Yeti 2014), I need to change the threshold from -50 dB to -30 dB to completely eliminate background noise (-35 dB occasionally lets noise pass through). While the threshold is something users are expected to adjust individually for their microphone, we should try to provide a good default that has an immediately noticeable effect (so people don't think the filter is not working).
Additionally, the release window of 50 ms feels too aggressive.1 If I say something in the microphone, the last sound will often be cut off quite a bit. I've found that a release window of 500 ms works well here, although it might be better to increase both the hold and release windows to lower values like 250 ms each. I suggest testing the defaults on various microphones (e.g. studio microphone and gaming headset) to make sure it has a reasonable effect out of the box.
Footnotes
-
This is one of my top pet peeves in a lot of VoIP apps. I get why it's done as a way to save a bit of bandwidth (which is debatable in 2024), but it distracts from the experience quite a bit. ↩
| @@ -0,0 +1,26 @@ | |||
| <?xml version="1.0" encoding="UTF-8" ?> | |||
| <class name="AudioEffectGate" inherits="AudioEffect" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="../class.xsd"> | |||
There was a problem hiding this comment.
I'm curious whether this should be called AudioEffectNoiseGate, so that searching for "noise" in the class reference lets you find this effect.
In this case, I'd make it clear in the description that the effect does not perform noise removal (in the sense of RNNoise reduction), but just cuts off audio if it's lower than a threshold.
Gate seemed like it was one of the effects obviously missing from the sfx that come with Godot, so I made a very basic one with only a threshold parameter.
This will hopefully have an attack/hold/release envelope.