Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autocompletion for Engine.get_singleton & similar #86753

Merged

Conversation

Mickeon
Copy link
Contributor

@Mickeon Mickeon commented Jan 3, 2024

Related to #86747.

Unlike the former PR, it's simple as that. If a bunch of methods are interfacing a collection of Strings of some sort, it can be auto-completed. There's a pattern down the line.

Can be backported to prior versions.

core/core_bind.h Outdated Show resolved Hide resolved
Copy link
Member

@AThousandShips AThousandShips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise

@Mickeon Mickeon force-pushed the autocompletion-engine-singletons branch from beebd72 to 5c87b6e Compare January 3, 2024 17:45
@akien-mga akien-mga modified the milestones: 4.x, 4.3 Jan 4, 2024
@akien-mga akien-mga merged commit 01e7c26 into godotengine:master Jan 4, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants