Commit transforms done with editor gizmo on tool mode switch. #86930
+35
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
When making several additions from suggestions please use the batch feature, it's next to the commit one 🙂 |
Thanks 😅 |
ryevdokimov
force-pushed
the
commit-transforms-on-mode-switch
branch
2 times, most recently
from
0b273b6 to
e683970
Compare
|
Changes made and tested. Thanks for your help AThousandShips. Edit: Nevermind I missed one... |
ryevdokimov
force-pushed
the
commit-transforms-on-mode-switch
branch
from
e683970 to
0748cbc
Compare
|
Ok, I think it's good. Let me know if I missed anything. |
ryevdokimov
force-pushed
the
commit-transforms-on-mode-switch
branch
from
0748cbc to
caa0f64
Compare
ryevdokimov
force-pushed
the
commit-transforms-on-mode-switch
branch
from
caa0f64 to
47561b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supplementary but not dependent on: #86805 and #86804
This affects 2D and 3D.
Currently you can switch gizmo tool modes while an edit is in progress, the tool will switch, but the previous tools action will continue, which is a bit strange.
2024-09-03.12-44-45.mp4
This PR will prevent this, by committing the transform in the editor when switching tool modes which seems like the more expected and less confusing result.
2024-09-03.12-52-22.mp4