Fix instant transformations not being committed when used in succession #96530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
bug
topic:editor
topic:3d
cherrypick:4.3
|
Related: #86930 |
ryevdokimov
suggested changes
Sep 3, 2024
|
Good catch, thank you! Fixed, and also disallowed starting instant transformations during a non-instant transformation (ie. when using the 3D gizmo). |
|
Good work, but unlike blender still, the object will immediately begin a transform if the keys are held down after mouse-down. Blender requires the key to be pressed again to start the process over. |
|
Fixed, thank you! |
|
Please squash commits into one, see PR workflow. |
Also: - Fix holding down keys repeatedly committing instant transformations, and disallow starting instant during non-instant - Fix echoed inputs starting new instant transformations after clicking to confirm, and disallow left mouse release committing instant transformations
ev13bird
force-pushed
the
issue-96527
branch
from
9448553 to
060a1a0
Compare
|
Squashed I think, thank you! |
akien-mga
approved these changes
Sep 5, 2024
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
|
Cherry-picked for 4.3.1. |
akien-mga
removed
the
cherrypick:4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #96527.
The "Begin Translate/Rotate/Scale Transformation" family of actions weren't being committed when activated in succession without confirming or canceling.
This meant that they would not be added to the undo/redo history.
Using multiple transformations in succession should now commit the previous transformation.
fixed.mp4