-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C#] Fix Encloses
failing on shared upper bound for AABB
and Rect2(I)
#87264
Conversation
Thank you so much, that was fast. I looked at godot/modules/mono/glue/GodotSharp/GodotSharp/Core/Rect2.cs Lines 123 to 128 in 7a90c56
|
Good point, will do in a bit, away from the computer for now, can do it in a separate one too, will check |
This comment was marked as outdated.
This comment was marked as outdated.
AABB.Encloses
failing on shared upper boundEncloses
failing on shared upper bound for AABB
and Rect2(I)
146ba0d
to
227a165
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
Thanks! |
Thank you! |
Cherry-picked for 4.2.2. |
C# version of:
AABB.encloses
failing on shared upper bound #871183.x version:
Encloses
failing on shared upper bound forAABB
andRect2
#87265