-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Overhaul AABB's documentation #87114
Conversation
84b4634
to
0c30d5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great generally! Will take a focused look when I have the time, thank you this is a class that needs some love
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have only checked the C# examples.
0c30d5c
to
1a960d4
Compare
1a960d4
to
e243df5
Compare
I modified the PR to change |
e243df5
to
8467245
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style and wording looks good, haven't verified the results
Note for cherry picking:
The encloses code is not applicable without cherry picking the changes to 4.1, e.g.
Thanks! |
Cherry-picked for 4.2.2. |
Very much related to #69816
This PR almost completely overhauls AABB's class reference documentation, and makes it match the current state of Rect2 and Rect2i.
Some of the documentation is ported 1:1 from Rect2's, but there are notable differences from Rect2:
Not everything was copied word-for-word, however.
intersect_ray()
andintersect_segment()
,get_endpoints()
, etc.;has_volume
:*_axis_*
methods;has_point
:godot/core/math/aabb.h
Lines 320 to 328 in 26b1fd0
If that statement were true, these would be
>=
, not>
.Feedback is very, very welcome. Thank you for the support in advance.