-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify that LightmapGI is not supported in compatibility renderer #88406
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to know, to not waste the developer's time testing
EDIT: Although, I guess that is only 4.3+, which, of course, isn't released yet. If we're only targeting the docs for 4.2 and below, then it's true that it isn't supported in those versions. |
And baking also works since 4.3+ too, the host system just needs to be able to run Vulkan at the moment even if you are in Compatibility mode. I feel the documentation should reflect the current state of the feature. EDIT: In that case it doesn't seem like a documentation change would be necessary? The original version reflects how it currently works after all. |
Pretend I retracted my approval until I figure how to do so. The documentation should be changed accordingly. Unless this PR is allowed to _specifically target 4.2 but that would be a major, major exception. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above (yippie).
It would still be nice if this was at least in 4.2.2, if possible. Which I think is still yet to have a release and will not have LightmapGI. |
c047238
to
3469850
Compare
In this case, you need to open a PR against the |
The documentation currently does not mention that LightmapGI rendering is not supported in the compatibility renderer. It only states the fact that baking it is not supported (thus it is possible to make an assumption that rendering it is supported, while baking isn't).
I'd originally wanted to reply in #75726 (comment) but appening this to documentation seemed fairly easy to do myself.