Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.2] Clarify that LightmapGI is not supported in compatibility renderer #88431

Merged
merged 1 commit into from
Feb 20, 2024
Merged

[4.2] Clarify that LightmapGI is not supported in compatibility renderer #88431

merged 1 commit into from
Feb 20, 2024

Conversation

vaartis
Copy link
Contributor

@vaartis vaartis commented Feb 17, 2024

#88406 but targeted at the 4.2 branch

The documentation currently does not mention that LightmapGI rendering is not supported in the compatibility renderer. It only states the fact that baking it is not supported (thus it is possible to make an assumption that rendering it is supported, while baking isn't).

@vaartis vaartis requested a review from a team as a code owner February 17, 2024 10:08
@AThousandShips AThousandShips changed the title Clarify that LightmapGI is not supported in compatibility renderer (in 4.2) [4.2] Clarify that LightmapGI is not supported in compatibility renderer Feb 17, 2024
@AThousandShips AThousandShips added this to the 4.2 milestone Feb 17, 2024
@Mickeon
Copy link
Contributor

Mickeon commented Feb 17, 2024

And I am to assume this could be cherrypicked to 4.1 as well?

@vaartis
Copy link
Contributor Author

vaartis commented Feb 17, 2024

Probably, since there's 4.1.4 still..

@Mickeon Mickeon added the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Feb 17, 2024
@akien-mga akien-mga merged commit 15a8022 into godotengine:4.2 Feb 20, 2024
15 checks passed
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 4.1.4.

@akien-mga akien-mga removed the cherrypick:4.1 Considered for cherry-picking into a future 4.1.x release label Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Calinou Calinou Calinou approved these changes

Assignees
No one assigned
Labels
documentation enhancement
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
5 participants
@vaartis @Mickeon @akien-mga @Calinou @AThousandShips