-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve user experience for VCS metadata generator menu button to mitigate accidentally overriding #88609
Conversation
Commit 6416791: Added a wacky hack which checks that the class name does not conflict with Needs work & needs to be tested for non-node extending scripts. P.S.: I'm unsure if this needs to be a separate pull request, and if that's possible with one already pending approval |
Updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works, but the text is updated only after restarting the editor. This can be solved by checking the file on the EditorFileSystem.filesystem_changed
signal or every time the popup is shown. In my opinion, this is an overkill, replacing "Create" with "Create/Override" or "Setup" will work too.
Also, please squash commits into one. To do this you need a local git client, GitHub web interface doesn't support it.
That's a better way of doing it, seems like it was a bit too ambitious in terms of performance, although it did lead to me learning new things, so this entire PR wasn't in vain :) |
Squashed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Please squash commits one more time (note that you can do this locally before force-push to save CI resources).
Squashed (not sure if I did it the right way however 🤔 ) |
You squashed it correctly, but adding "(squashed x2)" in the commit message was unnecessary. Once merged, it shouldn't matter to a reader whether that commit is the result of squashing multiple earlier commits or not, what matters is what the commit does :) If you can amend the commit with |
Thanks! |
Simply added a check to see if Git is already initialized, and if so, it would change the user interface to display
Override Version Control Metadata...
instead ofCreate Version Control Metadata...
to avoid confusion (just a polish, low priority).Please review the code and provide feedback as I am new to push requests.