[Core] Fix sharing of typed arrays from constructor

[AThousandShips]

This matches the copy constructor of Array when same typed, which I'd say is expected behavior

• Closes: C++ A deep copy (COW) of TypedArray is sometimes incorrectly made #89191

[AThousandShips]

Simplified this by delegating to avoid copying code

[adamscott]

I'm all in to simplify the code.

[AThousandShips]

Suggested change

	_FORCE_INLINE_ TypedArray(const Array &p_array) {
	set_typed(Variant::OBJECT, T::get_class_static(), Variant());
	_FORCE_INLINE_ TypedArray(const Array &p_array) :
	TypedArray() {

Alternatively, to reduce duplication even further

[AThousandShips]

Alternatively this block can be replaced by:

		if (p_array.get_typed_builtin() == Variant::OBJECT && p_array.get_typed_class_name() == T::get_class_static() && p_array.get_typed_script() == Variant()) {
			_ref(p_array);
		} else {
			set_typed(Variant::OBJECT, T::get_class_static(), Variant());
			assign(p_array);
		}

To avoid doing the typing part, though in either case it will allocate private data possibly unnecessarily

[adamscott]

though in either case it will allocate private data possibly unnecessarily

Then, I would keep the simplest version.

[AThousandShips]

Then I will and a future cleanup or improvement can hand that

[allenwp]

I just tried this PR and it fixes the issue using the minimum reproduction code that I shared in #89191.

[dsnopek]

This looks good to me!

After this change, is the Array(const Array &p_base, uint32_t p_type, const StringName &p_class_name, const Variant &p_script) constructor even used anywhere? If not, I wonder if it should be removed? Anyway, not important questions for now, things could be cleaned up more later :-)

[AThousandShips]

I think it's used in scripting, as the template can't be used in dynamic code, only static code, so in GDScript etc. the explicit constructor is relevant

Edit: it is used, for example here:

godot/modules/gdscript/gdscript_vm.cpp

Line 1672 in 93fc9b8

*dst = Array(array, builtin_type, native_type, *script_type);

[akien-mga]

Thanks!

[AThousandShips]

Thank you!