Fix how scripts reload outside of ScriptEditor

[paulloz]

• Relates to Allow Editor to reload external changes of scripts #82113
• Fixes 4.3 csharp files are changed on editor save causing issues in IDEs - regression? #89239
• Fixes Save in VS code in 4.3-dev5 #89029

#82113 made script being reloaded from outside ScriptEditor. The current Resource::reload_from_file() implementation indirectly calls Object::set_edited(true) on the script resource, so any script reloaded that way ends up being overwritten by the engine when a scene they are in is saved.

This is simply making sure we apply the same logic in Script::reload_from_file() as in ScriptEditor::reload_scripts(). Although, it feels quite weird that we purposefully call that method when Script::editor_can_reload_from_file() returns false.

[akien-mga]

CC @nongvantinh

[nongvantinh]

Hi @paulloz,

When Script::editor_can_reload_from_file() returns false, it means the Editor won't update to reflect new changes in that script. It will be updated through the internal script editor instead.

godot/core/object/script_language.h

Line 114 in 0ace0a1

virtual bool editor_can_reload_from_file() override { return false; } // this is handled by editor better

However, If the file is edited outside the editor and we don't use the internal editor, there's no way to get the latest changes. Consequently, whenever we use data of that file from ResourceCache, we always get outdated data, which can lead to issues requiring the most current and valid data. For instance, when we press Ctrl + S and the resource's state is marked as edited, then we save the current state of that script using state taken from ResourceCache, causing it to override the changes we made previously.

This problem stems from the Script::reload_from_file() method, which hasn't been used before. If it were, this issue would have occurred long ago. However, thanks to #82113, we now know that it doesn't function correctly.

[KoBeWi]

I can't reproduce the issue with GDScript, but the code looks fine.

[akien-mga]

Thanks!