Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use as_sortable_control() in SplitContainer #91728

Merged
merged 1 commit into from
May 14, 2024

Conversation

kitbdev
Copy link
Contributor

@kitbdev kitbdev commented May 8, 2024

Changed DockSplitContainer to improve the check, using get_containable_child() wasn't a great fit.

Made get_containable_child() private and renamed to match as_sortable_control() better.

Copy link
Member

@KoBeWi KoBeWi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't seem to break anything.

@akien-mga akien-mga modified the milestones: 4.x, 4.3 May 14, 2024
@akien-mga akien-mga merged commit 380f634 into godotengine:master May 14, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

@kitbdev kitbdev deleted the assimilate-split-container branch May 14, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants