Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTL] Add more list control options. #92749

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 4, 2024

Follow up to #92745, add some extra control for list:

  • Adds support for custom ordered list elements, and custom prefixes/suffixes:
  • Adds option to customize specific sublevel indentation size:
  • Adds option to break ordered list sublevels:

@bruvzg bruvzg added this to the 4.x milestone Jun 4, 2024
@bruvzg bruvzg requested review from a team as code owners June 4, 2024 08:48
@bruvzg bruvzg force-pushed the rtl_more_list_options branch from d6a8774 to ea98215 Compare June 4, 2024 09:07
@bruvzg bruvzg requested review from a team as code owners June 4, 2024 09:07
@KoBeWi
Copy link
Member

KoBeWi commented Jun 9, 2024

The quote got into the suffix:
image
I assume it's not expected?

[ol suffix=", "]
item 1
item 2
item 3
[ol]
lol
lo2
[/ol]
tiem 4
[/ol]

Also I don't get how suffix work. E.g. I tried a suffix with dot and space, but it doesn't do what I'd expect:

ufAtzwznqG.mp4

Though I also tried the different list types and their behavior is overall somewhat buggy >_>

@bruvzg
Copy link
Member Author

bruvzg commented Jun 9, 2024

Though I also tried the different list types and their behavior is overall somewhat buggy >_>

The indent (tab size) is too small, and lists are not actually taking bullet size into account (will check it and do a separate PR since it's not directly related to this change).

@bruvzg bruvzg force-pushed the rtl_more_list_options branch from ea98215 to 2a375c7 Compare June 9, 2024 20:05
@bruvzg
Copy link
Member Author

bruvzg commented Jun 9, 2024

The quote got into the suffix

Parsing space in the quotes seems to be issues with for all tags as well. Updated PR to use OptionMap instead of split and will do a separate PR to take it into account in the OptionMap (as well as move the rest of tags using split to OptionMap).

@Mickeon
Copy link
Contributor

Mickeon commented Jun 9, 2024

I wonder if the prefix and suffix arguments are really necessary, or if it would make more sense to pass a single String, which would then be formatted (e.g. [ol format="prefix_%s_suffix"]). Although, as far as I know, nothing in the Godot API ever does something like I described.

@KoBeWi
Copy link
Member

KoBeWi commented Jun 9, 2024

Well there is my old proposal for SpinBox godotengine/godot-proposals#4478

@Mickeon
Copy link
Contributor

Mickeon commented Jun 10, 2024

Which I also have happened to like already. Maybe the idea can be jumpstarted from here which is guaranteed to not break any compatibility.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants