Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RTL] Fix list item prefix width not taken into account. #92968

Merged
merged 1 commit into from
Jun 11, 2024
Merged

[RTL] Fix list item prefix width not taken into account. #92968

merged 1 commit into from
Jun 11, 2024

Conversation

bruvzg
Copy link
Member

@bruvzg bruvzg commented Jun 10, 2024

See #92749 (comment)

  • Shapes and stores prefixes and max. prefix width when shaping the rest of text instead of drawing it directly.
  • Adds missing shadow/outline drawing for prefixes.

@bruvzg bruvzg added this to the 4.3 milestone Jun 10, 2024
@bruvzg bruvzg force-pushed the rtl_list_indent branch from 4e91a8e to fff71db Compare June 10, 2024 10:15
@bruvzg bruvzg marked this pull request as ready for review June 10, 2024 19:21
@bruvzg bruvzg requested a review from a team as a code owner June 10, 2024 19:21
@akien-mga akien-mga merged commit 972839d into godotengine:master Jun 11, 2024
16 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug topic:gui
Projects
None yet
Milestone
4.3
Development

Successfully merging this pull request may close these issues.
2 participants
@bruvzg @akien-mga