Fix load error popup showing on every progress dialog #96830
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That's a funny regression from #93064.
When starting up the editor, if a file is read-only, a "Load errors" dialog should open to display the I/O errors. However, with the addition of a progress bar during editor startup, the "Load errors" dialog was opened while the Progress dialog was active, making the Progress dialog the parent of the "Load errors" dialog.
This caused the issue where the "Load errors" dialog would flash every time the Progress dialog was shown, displaying the same error from the editor startup repeatedly.
The reason why the error for the
editor_doc_cache
file only occurred in the dev build is that the case is not reconstructed every time in the release build.Also, I could not figure out why
adb.exe
was locking the file. I suspect there's an issue with Android Studio, but I'm not sure.I was tempted to add a removal of the
.tmp
file if the save was not successful, but I guess that would defeat the purpose of thebackup_save_enabled
feature.I modified
EditorNode
to prevent displayed the "Load errors" while a Progress dialog is opened and when the progress is closed, I open the "Load errors" dialog.