Fix empty load errors popup #97013
Merged
Fix empty load errors popup #97013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from #96830
I found this error while testing #97000 with a project using multiple scenes.
Depending on the timing when the io error occurs, the load errors popup could be visible when a scene is loaded.
After looking at it a bit, I found out that the parameter
p_clear_errorsinEditorProgress::load_scenewas always passed as true. So, I refactor the load errors a bit. It was easier to clear the errors only when the popup is closed. That fixed the issue while removing a useless parameter.