Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jitter shadow map dithering pattern across frames when TAA is enabled #97428

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

clayjohn
Copy link
Member

Supersedes: #61834
This closes godotengine/godot-proposals#4179 and closes #53534.

Credit to @Calinou who did most of the work. I just did some final cleanup to improve the quality before it was ready to merge

I ended up rebasing while working on the improvements described in #61834 (comment) so I figured it was less work overall for us to open a new PR.

This PR builds on the current state of #61834, see that PR for a full description/history

This improves shadow quality by reducing the visibility of the noisy
pattern caused by dithering.

This jittering also applies when FSR2 is enabled, as it provides its own
form of temporal antialiasing.

Co-authored-by: Clay John <claynjohn@gmail.com>
@hsvfan-jan
Copy link

Will the improved documentation of this comment of yours in #61834

We need to document that FSR2.2 at 1.0 scale is more sensitive to high contrast areas than TAA or FSR2.2 at lower scales as this will impact many users.

be included in another PR? I think it wouldn't be obvious why these artifacts will be found in various strengths in different locations in a level so documenting it would be great.

Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is co-authored by Clay and Hugo so it's pretty much peer reviewed already. Seems simple enough for me to approve for merge.

@clayjohn
Copy link
Member Author

Will the improved documentation of this comment of yours in #61834

We need to document that FSR2.2 at 1.0 scale is more sensitive to high contrast areas than TAA or FSR2.2 at lower scales as this will impact many users.

be included in another PR? I think it wouldn't be obvious why these artifacts will be found in various strengths in different locations in a level so documenting it would be great.

Yes, the docs are hosted in a separate repository. So the documentation update will necessarily be in another PR

@akien-mga akien-mga merged commit bfe74ec into godotengine:master Sep 26, 2024
19 checks passed
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants