Tweak environment tonemapping and adjustments for Godot 3.4 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Use the new ACES Fitted tonemapping for physically correct behavior of glowing lights. - Decrease overall saturation and contrast for a less jarring appearance.
|
Lowering the contrast and whitening bright lights is a subjective change, so I'd like to get feedback on this first. It may be better to instead/also lower the brightness of the blue lights, since AFAIK the deepish blue was the artistic intent. |
We could ask Fernando (the demo's artist) on Twitter about this 🙂 Does he have a GitHub account to comment on this issue? |
|
I like it! Looks very cinematic. I'm also all in for changing the attenuation curve of lights. |
|
I DM'd Fernando on Twitter and he told me that he really likes the new appearance. This should be good to merge once 3.4 is released 🙂 |
aaronfranke
approved these changes
Nov 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, I've thought about adding subtle ambient lighting to prevent some areas from being too dark, but this is likely better done in a separate PR. We could also increase some lights' ranges and tweak their attenuation, but this may impact performance negatively as lights may impact more meshes.
Note: Don't merge before Godot 3.4 is released to avoid breaking the scene's appearance in 3.3.x.
Preview