-
-
Notifications
You must be signed in to change notification settings - Fork 244
Demos with empty homepage and/or wrong posts list #682
Demos with empty homepage and/or wrong posts list #682
Comments
I believe I have fixed https://themes.gohugo.io/hugo-theme-zen/ now. Thanks for the work keeping the Themes section updated and relevant! |
@frjo Thanks the theme demo will be fixed when @digitalcraftsman updates the themes in the repo. |
The themes have been updated. |
The real impact of Hugo 0.57 breaking changes is even bigger than 155 themes, which stated above. What about broken taxonomies list pages? As an example, Mainroad. This theme is not listed (because homepage works), but it's affected too. I am sure this is not a complete list of affected themes. I have three themes in themes.gohugo.io and all of them affected somehow: Binario, blank, Mainroad. And worst of all, it was done without notification or any warning. I'll update my themes ASAP, but probably tomorrow, not today. |
There is a one month window so take your time. Also please note that #668 is in progress and I suggest you track it because the guidelines for maintaining a theme in the Hugo Showcase are about to change.. We are a very small team and this is the last time that I spend an exorbitant amount of time running around notifying 155 people. Thanks. |
I've created a fix for the Massively theme and would appreciate a review if anyone has chance: curtiscde/hugo-theme-massively#72 Thanks |
@onedrawingperday we could use Hugo's Twitter account to reach out to theme maintainers. Just let me know how to inform them in 280 characters. |
If you could tweet the following: Theme authors you may want to check out |
FWIW, and I know I'm probably in the minority here, I do not have a Twitter account. Please also consider using email, or a blog or something I can subscribe to. Alternatively, has anyone considered stabilizing Hugo or at least getting on some sort of release cycle so that theme authors have a chance to fix things before breaking changes are released? Having them just kind of spring up after a release if you're not heavily involved in Hugo development doesn't feel great. |
Also note that currently I have hit a GitHub limit. It seems that only 50 user mentions are allowed per post. So I cannot notify more people in the first post of this topic and it will not be practical for me to open issues in the different theme repositories or mention them in comments further down. I have contacted GitHub support for this, hopefully they will do something about it. So I m giving this a rest until tomorrow. |
Twitter is only an additional channel to reach a wider audience. I think it's more effective and less effort to broadcast this information before contacting the developers individually. Of course we we probably won't reach every developer this way. |
Thank you for your hard work, @onedrawingperday ! I'll fix my theme ASAP |
We are currently working on #668 and when that issue is resolved, we will put in writing that authors will need to keep an eye on current Hugo developments for making sure that a theme is functional with the latest version. We always give theme developers a 30 day period for fixing issues and up until now I have been contacting people for problems out of my own time. Breaking changes of the sort that happened in Hugo 0.57 are rare. Typically there is some kind of deprecation warning but in this case the changes in Pages Collections for the homepage etc. were done at once due to the development of new features like Cascading Front Matter. |
@bep is the lead developer behind Hugo. He should know best if a stable release cycle can be established and how the roadmap of Hugo will look like (incl. deprecations in future releases.) To cite him from #678 (comment):
|
@onedrawingperday I just posted a tweet: https://twitter.com/GoHugoIO/status/1162382902937735168 |
The Universal theme is also suffering from the same issue. |
Yes, contacting each developer individually doesn't seem sustainable. That's why I suggested a mailing list or blog, everyone can use RSS or everyone has an email, but not everyone has a Twitter. Email is universal, so in my mind it's probably the best place to start. |
This may also just be me, but just from reading the docs on the where page and from this post and the issue, I don't actually understand how to fix my theme. You suggest |
@onedrawingperday Thanks for informing, I'll fix my theme "Tikva" in the next days. Kind regards, |
I will look into your theme and let you know what you need to do in a bit. |
This closes #682 64 themes have been removed and 1 theme was updated.
You are more than welcome to re-submit your theme once it is fixed, as are all the other theme authors. I have made the commit that closed this issue slightly earlier. Thanks to all the authors who updated their themes. |
Thanks @onedrawingperday gohugoio/hugoThemes#682 Signed-off-by: Rick Cogley <rick.cogley@esolia.co.jp>
@onedrawingperday Hi, I have a patch commit early to fixes this problem but I forgot to change the other The early commit is g1eny0ung/hugo-theme-dream@dbf0c47. This commit should fix the problem. g1eny0ung/hugo-theme-dream@29cfa53. If you are free, can you help me see if this solves the problem? Very thanks. I already test it in my blog https://github.com/g1eny0ung/blog. Seems that all works fine. I re-submit in #717. |
@onedrawingperday Hi, I have noticed that hugo changelog theme (https://github.com/jsnjack/hugo-changelog-theme) has been removed from the themes page. I have already created a fix and reported it here #682 (comment) Do I need to change something else? |
In Hugo 0.57.0, a change was made that caused this theme to incorrectly render the recent posts. More information can be found [here](gohugoio/hugoThemes#682). This edit should fix that error. It has been tested on a live site and it works.
The changes in Hugo v.0.57.0 made this theme not showing posts on the homepage. See: gohugoio/hugoThemes#682 One line of code fixed this issue in the casper theme and made it work as in previous hugo versions
Due to the nature of the changes that were introduced in Hugo v.0.57.0 (briefly described in #678 (comment)) a great number of theme demos now display empty homepages and/or post lists that point to section lists (instead of individual posts).
The solution to the problem would be the use of mainSections for theme lists on the homepage (as we have been advocating for a while now) as well the following (or its variations) in list templates:
Hugo v.0.58.0 was released on the 4th of September 2019 and the breaking changes to the
home.Pages
collection that were reverted in 0.57.2 have been re-introduced Theme authors need to issue the fixes described above if they wish to keep their themes listed in the Hugo Showcase.- Broken themes will be removed around the end of September -
Also note that #668 is in progress and the guidelines for maintaining a theme in the Hugo Showcase are about to change. Theme authors are encouraged to track this issue.
- If you no longer plan to maintain a theme please let us know -
Furthermore there is a related notice in the forum to alert theme authors about the breaking changes.
Below is the full list of affected themes (I have not included the few themes whose authors are working on a fix as mentioned in #678 ):
Midnighttheme is affected by another issue and it will be kept in this repo until there is a resolution (even if its demo does not generate)Hugo Future Imperfect Slimfixed in pacollins/hugo-future-imperfect-slim@afbf3ccbYignyangfixed in joway/hugo-theme-yinyang@5091a6cHugo Flexfixed in ldeso/hugo-flex@0d64b46Hugo Lampfixed in huyb1991/hugo-lamp@b4408fdZenfixed in frjo/hugo-theme-zen@a942441Bingofixed in gundamew/hugo-bingo@ea9283fOneDly Projectfixed in cdeck3r/OneDly-Theme@3302b93Alpha Churchfixed (see WhiteList a few themes #687 )Minimagefixed in dsk52/minimage@959ef80Tikvafixed in geschke/hugo-tikva@af5722fAetherfixed in josephhutch/aether@0cf324bBinariofixed in Vimux/Binario@9f5ca76Newsprinttheme removed in Remove Newsprint Theme #685Indigofixed in AngeloStavrow/indigo@a824342eiiofixed in leonhe/hugo_eiio@cc47f86Base 16fixed in htdvisser/hugo-base16-theme@861b48aBlack & Lightfixed in davidhampgonsalves/hugo-black-and-light-theme@4168cd6Niellofixed in guangmean/Niello@cc55110Massivelyfixed in Fix homepage issues for Hugo 0.57.0 curtiscde/hugo-theme-massively#72Hyde-Hydefixed as per htr3n/hyde-hyde@ad9701bTechlog Simplefixed in mazgi/hugo-theme-techlog-simple@fdf9ccbArabicafixed in nirocfz/arabica@ae66e72Ezhilfixed in vividvilla/ezhil@3154483 and vividvilla/ezhil@bb28e76Inkblottyfixed in tosi29/inkblotty@a2b99bdPaperfixed in nanxiaobei/hugo-paper@68a57bbCaymanfixed in zwbetz-gh/cayman-hugo-theme@c5c1915Manisfixed in yursan9/manis-hugo-theme@30ff78aGhostwriterfixed in jbub/ghostwriter@6e9eabcEvenfixed in olOwOlo/hugo-theme-even@5a3e559Airfixed in syui/hugo-theme-air@3bc80b5Simplicityfixed in WhiteList a few themes #687Beautiful Hugofixed in halogenica/beautifulhugo@1d75ccdDusky Neon Potatofix in VVelox/hugo-dusky-neon-potato@a9bd193Paper CSSfixed in zwbetz-gh/papercss-hugo-theme@698fe6aHydefixed see: spf13/hyde@3080504Techdocwhitelisted in Whitelist a few themes #691Adam & Evefixed in blankoworld/hugo_theme_adam_eve@e925bcdCharakafixed in natarajmb/charaka-hugo-theme@de01c10Hugo Apps Themefixed in WhiteList a few themes #687XMinfixed in yihui/hugo-xmin@6123be2Pacmanfixed in coderzh/hugo-pacman-theme@ea7d497Lanyonfixed in tummychow/lanyon-hugo@33ecb36Pixyllfixed in azmelanar/hugo-theme-pixyll@c25f592[Minimal Bootstrap Hugo Themefixed in zwbetz-gh/minimal-bootstrap-hugo-theme@634920aKissfixed in ribice/kiss@7ea3147Hugo Duskfixed in gyorb/hugo-dusk@b0d2bc7Hugo W3 Simplefixed in jesselau76/hugo-w3-simple@601d63cNow UIfixed in cboettig/hugo-now-ui@82c3eb0Travelifyfixed in balaramadurai/hugo-travelify-theme@65f7a10 - also whitelisted in Whitelist a few themes #691hugo h5bpfixed in garvincasimir/hugo-h5bp-simple@f6b0f3aHerring Coveremoved in e736afeHugo Minimalist SPAfixed in Whitelist Hugo Minimalist SPA #683Lithiumfixed in jrutheiser/hugo-lithium-theme@fba4893BegUnmaintained theme removed in Remove Unmaintained Themes #69081. Denfixed in shaform/hugo-theme-den@553b158 - (also see: WhiteList a few themes #687 )Roboticowhitelisted in Whitelist a few themes #691Silhouettefixed in mattbutton/silhouette-hugo@be305fbOctopressfixed in parsiya/Hugo-Octopress@3f80deaBootstrap BPfixed in spech66/bootstrap-bp-hugo-theme@68314b7Oldnew Mashupwhitelisted in Whitelist a few themes #691Erfixed in lingxz/er@ebdb186Hugo Grapesfixed in shankar/hugo-grapes@af4af64Hugo Classicfixed in goodroot/hugo-classic@bafd650Hugo Nowfixed in [GH-682] Demos with empty homepage and/or wrong posts list mikeblum/hugo-now#5Dark Simplicityfix in kritoke/darksimplicity@e00dc41 and kritoke/darksimplicity@d516015Internet Weblogfixed in jnjosh/internet-weblog@2fa06ecSimple Afixed in alxschwarz/simple-a@b22f385Rustytheme removed in remove Rusty theme #699Hugo Cardsthe way this theme was refactored in bul-ikana/hugo-cards@e3248ef is not ideal, so I had to send Add detection of Section Posts in build script #706 to cover this setup in the Build Script.Cocoaunmaintained removed in Remove Cocoa theme #680Potato Darkfixed in surajmandalcell/potato-dark@241dea8Slimfixed in zhe/hugo-theme-slim@f666effBeyondNothingfixed in salcan/BeyondNothing@2931c2aLanding Pageunmaintained removed in Remove Unmaintained Themes #692Hugo Fraisfixed in the2ne/hugo-frais@cd01972 and the2ne/hugo-frais@056db8fWavefixed in syui/hugo-theme-wave@68e2aedPaperbackfixed in dashdashzako/paperback@9b58ebaonetwothreefixed in Fix homepage for hugo>=0.58.0 schollz/onetwothree#12Elephantsfixed in meibenny/elephants@7c40d2cReveal JSwhitelisted in Whitelist a few themes #691Gentooremoved in 7fdec13Liquoricefixed in eliasson/liquorice@4f2af3bHikarifixed in digitalcraftsman/hugo-hikari-theme@314516aJournalremoved in Remove Journal theme #694Light Hugofixed in tblyler/light-hugo@5ef28a4Hugo Scrollunmaintained and removed in Remove Unmaintained Themes #692Hugo Unounmaintained and removed in Remove more themes #693Hugo Zenunmaintained and removed in Remove more themes #693Remark Twemojiremoved in Remove Unmaintained Themes #690Remark Minionremoved in Remove Unmaintained Themes #690Nixonremoved in d46f2d5 also see Demos with empty homepage and/or wrong posts list #682 (comment)Twenty Fourteenfixed in jaden/twentyfourteen@89e9097Gindororemoved in Remove Unmaintained Themes #690Shioriremoved in Remove Unmaintained Themes #690The text was updated successfully, but these errors were encountered: