Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Feast installation doc #207

Merged
merged 20 commits into from
May 30, 2019
Merged

Update Feast installation doc #207

merged 20 commits into from
May 30, 2019

Conversation

davidheryanto
Copy link
Collaborator

@davidheryanto davidheryanto commented May 29, 2019

With latest Feast release 0.1.1, the previous installation doc is no longer valid.
This pull request updates the Feast installation doc, including step-by-step commands for setting up Feast infrastructure and configuration.

It's a bit verbose, but I think it's easier for people not that familiar with Google Cloud and Kubernetes to get started.

The updated installation quickstart doc can be viewed from this link:
https://github.com/gojek/feast/blob/installation-doc/docs/install.md

NOTE:
If you want to test this pull request by following the commands in the
the new install.md make sure you do:
git clone https://github.com/gojek/feast
git checkout installation-doc

Since this pull request updates some of the chart definition and the install
guide includes installing Feast from local chart path

@feast-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: davidheryanto

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@davidheryanto
Copy link
Collaborator Author

/hold
Need to fix integration-test

@davidheryanto
Copy link
Collaborator Author

/hold cancel
integration-test fixed

@pradithya
Copy link
Collaborator

/lgtm

@feast-ci-bot feast-ci-bot merged commit 330189d into master May 30, 2019
@davidheryanto davidheryanto deleted the installation-doc branch May 31, 2019 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants