Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test/integration/goDebug: remote attach test is flaky #1456

Open
hyangah opened this issue Apr 27, 2021 · 5 comments
Open

test/integration/goDebug: remote attach test is flaky #1456

hyangah opened this issue Apr 27, 2021 · 5 comments
Labels
chore/testing issues related to bugs in test, CI setup debug/remote issues related to remote debugging support Debug Issues related to the debugging functionality of the extension.
Milestone
vscode-go/backlog

Comments

@hyangah
Copy link
Contributor

hyangah commented Apr 27, 2021

The remote test is flaky and is blocking releases.

    remote attach

Sending initializing request for remote attach setup.

Setting up attach request for {"name":"Attach","type":"go","request":"attach","mode":"remote","host":"127.0.0.1","port":39411,"packagePathToGoModPathMap":{"/home/runner/go/src/test/testfixture":"/home/runner/go/src/test/testfixture","/home/runner/go/src/test/testfixture/baseTest":"","/home/runner/go/src/test/testfixture/gogetdocTestData":"","/home/runner/go/src/test/testfixture/completions":"","/home/runner/go/src/test/testfixture/testTags":"","/tmp/legacy8KOQJ6/testfixture/baseTest":"/tmp/legacy8KOQJ6/testfixture/baseTest","/tmp/legacy8KOQJ6/testfixture/completions":"/tmp/legacy8KOQJ6/testfixture/completions","/tmp/legacy8KOQJ6/testfixture/testTags":"/tmp/legacy8KOQJ6/testfixture/testTags"},"apiVersion":2,"dlvLoadConfig":{"followPointers":true,"maxVariableRecurse":1,"maxStringLen":64,"maxArrayValues":64,"maxStructFields":-1},"showGlobalVariables":false,"cwd":"${workspaceFolder}","debugAdapter":"legacy","dlvToolPath":"/home/runner/go/bin/dlv"}.

Sending configuration done request for remote attach setup.

      ✓ can connect and initialize using external dlv --headless --accept-multiclient=true --continue=true (10310ms)

      1) "after each" hook for "can connect and initialize using external dlv --headless --accept-multiclient=true --continue=true"
      ...

  1) Go Debug Adapter Tests (legacy)
       "after each" hook for "can connect and initialize using external dlv --headless --accept-multiclient=true --continue=true":
     Error: Timeout of 60000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (/home/runner/work/vscode-go/vscode-go/out/test/integration/goDebug.test.js)
  	at listOnTimeout (internal/timers.js:554:17)
  	at processTimers (internal/timers.js:497:7)
@hyangah hyangah added the Debug Issues related to the debugging functionality of the extension. label Apr 27, 2021
@hyangah hyangah added this to the On Deck milestone Apr 27, 2021
@suzmue
Copy link
Contributor

suzmue commented Apr 27, 2021

Looks like the flaky issue is in the teardown logic, I'll send a patch to try to mitigate the issue.

@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/314289 mentions this issue: test/integration/goDebug: skip remote attach tests

gopherbot pushed a commit that referenced this issue Apr 27, 2021
@hyangah
test/integration/goDebug: skip remote attach tests
a496b7a 
This is a temporary change to unblock the nightly release.
Once released, we will revert this change.

Updates #1456

Change-Id: If65f595eccc634a52b8dce972944e3202391be8f
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/314289
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/314329 mentions this issue: test/integration/goDebug: skip more remote attach tests

gopherbot pushed a commit that referenced this issue Apr 27, 2021
@hyangah
test/integration/goDebug: skip more remote attach tests
c5ca0dc 
Updates #1456

Change-Id: Idebc1305128b18e5e8c07acce7bb4ead5e83c915
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/314329
Trust: Hyang-Ah Hana Kim <hyangah@gmail.com>
Run-TryBot: Hyang-Ah Hana Kim <hyangah@gmail.com>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/314389 mentions this issue: .github/workflows: install stable delve version for testing

hyangah added a commit to hyangah/vscode-go that referenced this issue Apr 27, 2021
@hyangah
test/integration/goDebug: skip more remote attach tests
dd9b688 
Updates golang#1456

Change-Id: Idebc1305128b18e5e8c07acce7bb4ead5e83c915
hyangah pushed a commit to hyangah/vscode-go that referenced this issue Apr 28, 2021
@suzmue @hyangah
.github/workflows: install stable delve version for testing
1c12a80 
The extension maintains two dlv binaries for debugging, a stable
version of dlv for the legacy adapater and dlv built from master
to be used with dlv dap, which is under active development. For
testing we should use the stable version of delve for the legacy,
and only use master for dlv-dap.

Updates golang#1456

Change-Id: Ie4482aebb4fee1579896702faca207182b4746c3
@hyangah
Copy link
Contributor Author

hyangah commented Apr 28, 2021

Skipping those tests didn't seem to be sufficient. I will retry to release nightly after @suzmue's pending changes to address the underlying issue and cl/314589 are submitted.

gopherbot pushed a commit that referenced this issue May 5, 2021
@suzmue
.github/workflows: install stable delve version for testing
f5ef2de 
The extension maintains two dlv binaries for debugging, a stable
version of dlv for the legacy adapater and dlv built from master
to be used with dlv dap, which is under active development. For
testing we should use the stable version of delve for the legacy,
and only use master for dlv-dap.

Updates #1456

Change-Id: Ie4482aebb4fee1579896702faca207182b4746c3
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/314389
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
lggomez pushed a commit to lggomez/vscode-go-1 that referenced this issue May 6, 2021
@suzmue @lggomez
.github/workflows: install stable delve version for testing
6b32df1 
The extension maintains two dlv binaries for debugging, a stable
version of dlv for the legacy adapater and dlv built from master
to be used with dlv dap, which is under active development. For
testing we should use the stable version of delve for the legacy,
and only use master for dlv-dap.

Updates golang#1456

Change-Id: Ie4482aebb4fee1579896702faca207182b4746c3
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/314389
Trust: Suzy Mueller <suzmue@golang.org>
Run-TryBot: Suzy Mueller <suzmue@golang.org>
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Hyang-Ah Hana Kim <hyangah@gmail.com>
@polinasok polinasok added the chore/testing issues related to bugs in test, CI setup label Mar 18, 2022
@polinasok polinasok added the debug/remote issues related to remote debugging support label Mar 30, 2022
@polinasok polinasok mentioned this issue Apr 22, 2022
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
chore/testing issues related to bugs in test, CI setup debug/remote issues related to remote debugging support Debug Issues related to the debugging functionality of the extension.
Projects
None yet
Milestone
vscode-go/backlog
Development

No branches or pull requests
4 participants
@hyangah @suzmue @gopherbot @polinasok