Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug: change the default adapter for remote attach to dlv-dap #2205

Closed
3 tasks done
polinasok opened this issue Apr 22, 2022 · 3 comments
Closed
3 tasks done

debug: change the default adapter for remote attach to dlv-dap #2205

polinasok opened this issue Apr 22, 2022 · 3 comments
Labels
Debug Issues related to the debugging functionality of the extension.
Milestone
v0.41.0

Comments

@polinasok
Copy link
Contributor

polinasok commented Apr 22, 2022 •
edited by hyangah
Loading

--

Update:
@polinasok polinasok added the Debug Issues related to the debugging functionality of the extension. label Apr 22, 2022
@gopherbot gopherbot added this to the Untriaged milestone Apr 22, 2022
@polinasok polinasok changed the title debug: change the default adapter for remote attach to be dlv-dap debug: change the default adapter for remote attach to dlv-dap Apr 22, 2022
@polinasok polinasok mentioned this issue Apr 22, 2022
Closed
@hyangah hyangah mentioned this issue Apr 25, 2022
Closed
3 tasks
@hyangah
Copy link
Contributor

hyangah commented Apr 25, 2022 •
edited
Loading

go-delve/delve#2958 looks like too big a change.

Assuming some problems listed there may occur in the legacy adapter based session, can you please help identifying the feature gap and deliverables? (for example, "A halt from a new connection on entry." - is the legacy adapter handling this case better? how frequent and severe is the problem?)

@hyangah hyangah modified the milestones: Untriaged, On Deck Apr 28, 2022
@hyangah hyangah modified the milestones: vscode-go/backlog, v0.41.0 Aug 30, 2023
@hyangah hyangah mentioned this issue Aug 30, 2023
Closed
@hyangah hyangah mentioned this issue Dec 18, 2023
Open
1 task
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/550917 mentions this issue: src/goDebugConfiguration: change remote/attach default to dlv-dap

gopherbot pushed a commit that referenced this issue Dec 27, 2023
@hyangah
src/goDebugConfiguration: change remote/attach default to dlv-dap
60c8ec9 
And warn users who are affected by this change.

For #2205
For #3096

Change-Id: Ie74b0f2d02b1f64d984d1120463f0b01328e2bb0
Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/550917
TryBot-Result: kokoro <noreply+kokoro@google.com>
Reviewed-by: Suzy Mueller <suzmue@golang.org>
Commit-Queue: Hyang-Ah Hana Kim <hyangah@gmail.com>
@gopherbot
Copy link
Collaborator

Change https://go.dev/cl/562678 mentions this issue: docs: update the debugging doc about remote mode default adapter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Debug Issues related to the debugging functionality of the extension.
Projects
None yet
Milestone
v0.41.0
Development

No branches or pull requests
3 participants
@hyangah @gopherbot @polinasok