fix #416: Add skip-dirs-use-default #630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is blocked/failing because of the SVG generation This would be unblocked by merging #625 |
ernado
reviewed
Aug 29, 2019
pkg/lint/runner.go
Outdated
| skipDirs = append(skipDirs, cfg.Run.SkipDirs...) | ||
| skipDirs := cfg.Run.SkipDirs | ||
| if cfg.Run.UseDefaultSkipDirs { | ||
| skipDirs = append([]string{}, packages.StdExcludeDirRegexps...) |
There was a problem hiding this comment.
Hey @Sean-Der, great to meet you :)
Does it mean that skip-dirs-use-default: true (which will be true by default) will replace the explicit skip-dirs setting?
skipDirs := cfg.Run.SkipDirs // ["e2e", "foo/bar"]
if cfg.Run.UseDefaultSkipDirs {
skipDirs = append([]string{}, packages.StdExcludeDirRegexps...)
}
skipDirs // is now equal to packages.StdExcludeDirRegexpsProbably we want the skipDirs = append(skipDirs, packages.StdExcludeDirRegexps...) here?
There was a problem hiding this comment.
Hi @ernado my name is Sean.
Oh nice catch, fixed!
ernado
approved these changes
Aug 29, 2019
|
Hi, thank you! |
jirfag
added a commit
that referenced
this pull request
Sep 10, 2019
Also, output help for the new option in a more compact way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this is ok @jirfag!
This will make big difference for Pion. The more we crank up the linter the easier it gets to be a maintainer :) thanks again for golangci-lint, it has made a huge difference.