-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Samsung SM-T585 crashes and turns off or restart. #3257
Comments
As this issue is considered to be device specific, would there be a way to address this to Samsung? On our side we do not appear to have direct access to any support channel. I have requested our customer to indicate if more devices appear to be impacted with this issue. |
We have received an update from our customer:
Is there any way to highlight this issue to Samsung via Exoplayer team? Afterwards this does not appear to require a fix on Exoplayer side. |
Please can you provide a list of tablets actually tested and confirmed to have the issue? Thanks. |
Please could you also provide some kind of reference to the issue Samsung is aware of? I think we have a candidate workaround at the application layer, but without knowing what that issue was or a list of affected devices, it's pretty hard for us to validate that we're doing the right thing. Thanks. |
d346266 should work around this issue on SM-T585. Expanding the workaround to more devices is pending receipt of more information, as requested above. Thanks. |
Thanks for the effort for a possible workaround. I have again requested our customer an update with regards to tested devices on their side. I hope to provide an update soon. We have retested this on our side again with the device which was shipped to us. The issue does not appear to occur for all streams which are used in the app (originating from multiple streaming platforms). |
Our customer plans to provide feedback about impacted devices by the end of this week. Once available I will forward these. |
Hi Mark86NL, Any update? |
The same problem reproduced on Samsung Galaxy J1 (Android 5.1.1) When you plan to include this workaround? |
@nicolassabin35 I have received response from our customer who performed some tests in combination with Samsung locally. The SM-T585 - Tab A is the only device where the issue was reproduced. |
As above, d346266 should fix the issue for the SM-T585. @fragmentic - How did you validate that the issue you're seeing is the same? Please can you try modifying |
@ojw28 our customer also identified another device SM-A520F (Samsung Galaxy A5 2017) which has this issue on Android 7.0. How would you suggest to proceed with this? Can this be added as a device specific workaround? |
@ojw28 I have noticed this issue was reopened. Would there any feedback required from our side in order to add above mentioned device for this fix? Or was this reopened for another reason? We are currently planning some updates for our Android apps and would like to see if we could include these fixes there |
Is the customer able to confirm that the same fix works for the SM-A520F as well? You could verify this by providing them with a build of the app in which I'm hesitant to enable the workaround for the additional device without someone validating that it resolves the issue, because it's easy to conflate multiple issues of this type together (i.e. assume they're the same when in fact they're different). If this can be validated, we'll merge a change. Or better, please send us a pull request. Else we will have to get hold of one of these devices to validate on our side, however this may take some time. Thanks! |
Tested on SM-T585 and can confirm it is fixed for that device. |
We need confirmation for the SM-A520F for it to be added to the workaround list. |
Also received feedback for SM-A520F that the same workaround worked there based on the test app we provided. |
Issue: #3355 Issue: #3257 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=172587141
Issue: #3355 Issue: #3257 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=172587141
@ojw28 a customer has reported this exact issue on two other Samsung devices:
We don't have those devices in our possession, but if a workaround is possible we can forward the version to the customer. |
|
@ojw28 the model (in Build.MODEL) is Do you have any insights about why this happens? |
Ah. I think SM-A5 might be overly broad (and may also include yet-to-be-released devices). I'll add SM-510 explicitly for now. |
What is the reason for this issue, and why does the workaround work? |
Something goes wrong in the decoder when adaptation occurs. I don't have access to the decoder implementation, so it's impossible to say exactly what's broken. Queuing the blank frame likely forces the decoder to better reset its internal state. |
Issue: #3257 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=174686747
Issue: #3257 ------------- Created by MOE: https://github.com/google/moe MOE_MIGRATED_REVID=174686747
Issue description
Device turns off or restarts after playback of a stream (stream with DRM license provided by mail).
It's probably related to auto quality change because sometimes it could play very long till I enable random adaptation and sometimes it just crashes few seconds after start.
Reproduction steps
Link to test content
stream with DRM license provided by mail
Version of ExoPlayer being used
r2.5.2
Device(s) and version(s) of Android being used
Samsung SM-T585
Android: 7.0
Build number: NRD90M.T585XXU2BQE4
A full bug report captured from the device
In all tests 2 warnings and one error repeats:
...
Full Log (additional two provided by email).
The text was updated successfully, but these errors were encountered: