Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing bazel dependencies for host/libs/directories #788

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

Databean
Copy link
Member

@Databean Databean commented Nov 7, 2024

No description provided.

@Databean Databean force-pushed the fix_login branch 2 times, most recently from 4bc8a63 to e5a728e Compare November 8, 2024 00:03
@Databean Databean marked this pull request as ready for review November 8, 2024 00:08
@Databean Databean added kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Nov 8, 2024
@Databean
Copy link
Member Author

Databean commented Nov 8, 2024

Thanks for reviewing!

@Databean Databean merged commit 21482da into google:main Nov 8, 2024
6 checks passed
@Databean Databean removed kokoro:force-run Trigger a presubmit build unconditionally. kokoro:run Run e2e tests. labels Nov 8, 2024
Databean added a commit to Databean/android-cuttlefish that referenced this pull request Nov 8, 2024
This avoids cases like
google#788 fixing
google#771 by enforcing
stricter rules to match the behavior of the internal build system.

Bug: b/377996634
@Databean Databean mentioned this pull request Nov 8, 2024
Databean added a commit to Databean/android-cuttlefish that referenced this pull request Nov 9, 2024
https://bazel.build/docs/bazel-and-cpp#toolchain-features

This avoids cases like
google#788 fixing
google#771 by enforcing
stricter rules to match the behavior of the internal build system.

Bug: b/377996634
Databean added a commit that referenced this pull request Nov 9, 2024
https://bazel.build/docs/bazel-and-cpp#toolchain-features

This avoids cases like
#788 fixing
#771 by enforcing
stricter rules to match the behavior of the internal build system.

Bug: b/377996634
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants