Stricter bazel builds #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ser-io
approved these changes
Nov 8, 2024
jemoreira
approved these changes
Nov 8, 2024
https://bazel.build/docs/bazel-and-cpp#toolchain-features This validates that all exported header files compile in isolation with a c++ compiler. Bug: b/377996634
https://bazel.build/docs/bazel-and-cpp#toolchain-features This avoids cases like google#788 fixing google#771 by enforcing stricter rules to match the behavior of the internal build system. Bug: b/377996634
Databean
force-pushed
the
strict_bazel
branch
from
e59e418
to
d83a720
Compare
|
Thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids cases like #788 fixing #771 by enforcing stricter rules to match the behavior of the internal build system.